On Tue, 17 Dec 2013, Vytas Dauksa wrote: > Introduce packet mark mask for hash:ip,mark data type. This allows to > set mark bit filter for the ip set. Why it's important that the kernel should mask the mark value, when the user could add the intended value directly? The only case where it's required when entries added/deleted by the SET target. It's more natural for me if the markmask value has a meaning and effect for kernel side add/del operations only, and ignored for user add/del/test and kernel tests. What's your opinion? A small thing, but I'd prefer if the mark value were printed/saved in hex instead of decimal, similarly to iptables. Better introduce a new print function for it. Best regards, Jozsef - E-mail : kadlec@xxxxxxxxxxxxxxxxx, kadlecsik.jozsef@xxxxxxxxxxxxx PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences H-1525 Budapest 114, POB. 49, Hungary -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
