On Wed, Jan 08, 2014 at 01:20:51PM +0100, Arturo Borrero Gonzalez wrote: > On 8 January 2014 00:18, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > > > > We don't save any ifdef. > > Well, we need at least one ifdef per format. I don't see how we can > get rid of them. > > This patch just condensates the logic to one single point, also adding > the void definition, which is good for other patches in the series. OK, then you have to include in the description that it simplifies follow-up patches and in what way. But I also rised some concerns on the follow-up patches that you have to address. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
