On 6 January 2014 13:29, Kristian Evensen <kristian.evensen@xxxxxxxxx> wrote: > From: Kristian Evensen <kristian.evensen@xxxxxxxxx> > > This patch adds support for the connmark target. > > Signed-off-by: Kristian Evensen <kristian.evensen@xxxxxxxxx> > + > +/* Even though nfmask and ctmark is mutually exclusive, do not use union here. > + * The user can provide incorrect json/xml input containing both values. */ > +struct nft_expr_connmark { > + uint32_t ctmark; > + uint32_t ctmask; > + uint32_t nfmask; > + uint8_t mode; > +}; Hi Kristian, you can use the union if you want, see [0] about the situation in XML and [1] in JSON. Regards. [0] http://git.netfilter.org/libnftables/tree/src/expr/meta.c?h=next-3.14#n236 [1] http://git.netfilter.org/libnftables/tree/src/expr/meta.c?h=next-3.14#n195 -- Arturo Borrero González -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html