On Sat, 4 Jan 2014 13:16:48 +0000
Patrick McHardy <kaber@xxxxxxxxx> wrote:
> On Sat, Jan 04, 2014 at 02:10:43PM +0100, Jesper Dangaard Brouer wrote:
> > Avoid potentially spamming the kernel log with WARN splash messages
> > when catching wrong usage of seqadj, by simply using WARN_ONCE.
> >
> > This is a followup to commit db12cf274353 (netfilter: WARN about
> > wrong usage of sequence number adjustments)
> >
> > Suggested-by: Flavio Leitner <fbl@xxxxxxxxxx>
> > Suggested-by: Daniel Borkmann <dborkman@xxxxxxxxxx>
> > Suggested-by: Florian Westphal <fw@xxxxxxxxx>
> > Signed-off-by: Jesper Dangaard Brouer <brouer@xxxxxxxxxx>
> > ---
> > Nitpick found by internal RedHat review process ;-)
> >
> > net/netfilter/nf_conntrack_seqadj.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/net/netfilter/nf_conntrack_seqadj.c b/net/netfilter/nf_conntrack_seqadj.c
> > index b2d38da..f6e2ae9 100644
> > --- a/net/netfilter/nf_conntrack_seqadj.c
> > +++ b/net/netfilter/nf_conntrack_seqadj.c
> > @@ -37,7 +37,7 @@ int nf_ct_seqadj_set(struct nf_conn *ct, enum ip_conntrack_info ctinfo,
> > return 0;
> >
> > if (unlikely(!seqadj)) {
> > - WARN(1, "Wrong seqadj usage, missing nfct_seqadj_ext_add()\n");
> > + WARN_ONCE(1, "Missing nfct_seqadj_ext_add() setup call\n");
> > return 0;
>
> I missed the patch that added the WARN. Since when do we add runtime checks
> for API misuse instead of simply letting it crash?
We changed an existing API which broke IPVS. And I think we still have
a use-case in IPVS, which can hit this case/bug, thus I added a stack
dump warning (instead of crashing), so I can catch this use-case and
fix it later.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
