This patch adds userspace support for the meta expression in the set flavour.
This expression indicates that the packet has to be set with a property,
currently one of mark, priority or nftrace.
Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@xxxxxxxxx>
---
v1: initial release of the patch
v2: address comments from Tomasz in the kernel side: respect the order of the
enums. Also, other cleanups.
v3: use a nftables register to set the given packet value.
include/libnftables/expr.h | 1
include/linux/netfilter/nf_tables.h | 4 +
src/expr/meta.c | 116 ++++++++++++++++++++++++------
tests/jsonfiles/65-rule-meta-target.json | 1
tests/xmlfiles/76-rule-meta_target.xml | 1
5 files changed, 98 insertions(+), 25 deletions(-)
create mode 100644 tests/jsonfiles/65-rule-meta-target.json
create mode 100644 tests/xmlfiles/76-rule-meta_target.xml
diff --git a/include/libnftables/expr.h b/include/libnftables/expr.h
index 54de186..0194cbe 100644
--- a/include/libnftables/expr.h
+++ b/include/libnftables/expr.h
@@ -50,6 +50,7 @@ enum {
enum {
NFT_EXPR_META_KEY = NFT_RULE_EXPR_ATTR_BASE,
NFT_EXPR_META_DREG,
+ NFT_EXPR_META_SREG,
};
enum {
diff --git a/include/linux/netfilter/nf_tables.h b/include/linux/netfilter/nf_tables.h
index fbfd229..4a02b8b 100644
--- a/include/linux/netfilter/nf_tables.h
+++ b/include/linux/netfilter/nf_tables.h
@@ -552,12 +552,14 @@ enum nft_meta_keys {
* enum nft_meta_attributes - nf_tables meta expression netlink attributes
*
* @NFTA_META_DREG: destination register (NLA_U32)
- * @NFTA_META_KEY: meta data item to load (NLA_U32: nft_meta_keys)
+ * @NFTA_META_KEY: meta data item to load or set (NLA_U32: nft_meta_keys)
+ * @NFTA_META_SREG: source register (NLA_U32)
*/
enum nft_meta_attributes {
NFTA_META_UNSPEC,
NFTA_META_DREG,
NFTA_META_KEY,
+ NFTA_META_SREG,
__NFTA_META_MAX
};
#define NFTA_META_MAX (__NFTA_META_MAX - 1)
diff --git a/src/expr/meta.c b/src/expr/meta.c
index 88d2908..6899d69 100644
--- a/src/expr/meta.c
+++ b/src/expr/meta.c
@@ -28,7 +28,10 @@
struct nft_expr_meta {
uint8_t key; /* enum nft_meta_keys */
- uint8_t dreg; /* enum nft_registers */
+ union {
+ uint8_t dreg; /* enum nft_registers */
+ uint8_t sreg; /* enum nft_registers */
+ };
};
static int
@@ -44,6 +47,9 @@ nft_rule_expr_meta_set(struct nft_rule_expr *e, uint16_t type,
case NFT_EXPR_META_DREG:
meta->dreg = *((uint32_t *)data);
break;
+ case NFT_EXPR_META_SREG:
+ meta->sreg = *((uint32_t *)data);
+ break;
default:
return -1;
}
@@ -63,6 +69,9 @@ nft_rule_expr_meta_get(const struct nft_rule_expr *e, uint16_t type,
case NFT_EXPR_META_DREG:
*data_len = sizeof(meta->dreg);
return &meta->dreg;
+ case NFT_EXPR_META_SREG:
+ *data_len = sizeof(meta->sreg);
+ return &meta->sreg;
}
return NULL;
}
@@ -78,6 +87,7 @@ static int nft_rule_expr_meta_cb(const struct nlattr *attr, void *data)
switch(type) {
case NFTA_META_KEY:
case NFTA_META_DREG:
+ case NFTA_META_SREG:
if (mnl_attr_validate(attr, MNL_TYPE_U32) < 0) {
perror("mnl_attr_validate");
return MNL_CB_ERROR;
@@ -98,6 +108,8 @@ nft_rule_expr_meta_build(struct nlmsghdr *nlh, struct nft_rule_expr *e)
mnl_attr_put_u32(nlh, NFTA_META_KEY, htonl(meta->key));
if (e->flags & (1 << NFT_EXPR_META_DREG))
mnl_attr_put_u32(nlh, NFTA_META_DREG, htonl(meta->dreg));
+ else if (e->flags & (1 << NFT_EXPR_META_SREG))
+ mnl_attr_put_u32(nlh, NFTA_META_SREG, htonl(meta->sreg));
}
static int
@@ -116,6 +128,9 @@ nft_rule_expr_meta_parse(struct nft_rule_expr *e, struct nlattr *attr)
if (tb[NFTA_META_DREG]) {
meta->dreg = ntohl(mnl_attr_get_u32(tb[NFTA_META_DREG]));
e->flags |= (1 << NFT_EXPR_META_DREG);
+ } else if (tb[NFTA_META_SREG]) {
+ meta->sreg = ntohl(mnl_attr_get_u32(tb[NFTA_META_SREG]));
+ e->flags |= (1 << NFT_EXPR_META_SREG);
}
return 0;
@@ -164,14 +179,9 @@ static int nft_rule_expr_meta_json_parse(struct nft_rule_expr *e, json_t *root)
{
#ifdef JSON_PARSING
const char *key_str;
- uint32_t reg;
+ uint32_t reg, sreg;
int key;
- if (nft_jansson_parse_reg(root, "dreg", NFT_TYPE_U32, ®) < 0)
- return -1;
-
- nft_rule_expr_set_u32(e, NFT_EXPR_META_DREG, reg);
-
key_str = nft_jansson_parse_str(root, "key");
if (key_str == NULL)
return -1;
@@ -182,6 +192,19 @@ static int nft_rule_expr_meta_json_parse(struct nft_rule_expr *e, json_t *root)
nft_rule_expr_set_u32(e, NFT_EXPR_META_KEY, key);
+ if (nft_jansson_node_exist(root, "dreg")) {
+ if (nft_jansson_parse_reg(root, "dreg", NFT_TYPE_U32, ®) < 0)
+ return -1;
+
+ nft_rule_expr_set_u32(e, NFT_EXPR_META_DREG, reg);
+ } else if (nft_jansson_node_exist(root, "sreg")) {
+ if (nft_jansson_parse_reg(root, "sreg",
+ NFT_TYPE_U32, &sreg) < 0)
+ return -1;
+
+ nft_rule_expr_set_u32(e, NFT_EXPR_META_SREG, sreg);
+ }
+
return 0;
#else
errno = EOPNOTSUPP;
@@ -198,13 +221,6 @@ static int nft_rule_expr_meta_xml_parse(struct nft_rule_expr *e, mxml_node_t *tr
int32_t reg;
int key;
- reg = nft_mxml_reg_parse(tree, "dreg", MXML_DESCEND_FIRST);
- if (reg < 0)
- return -1;
-
- meta->dreg = reg;
- e->flags |= (1 << NFT_EXPR_META_DREG);
-
key_str = nft_mxml_str_parse(tree, "key", MXML_DESCEND_FIRST,
NFT_XML_MAND);
if (key_str == NULL)
@@ -217,6 +233,19 @@ static int nft_rule_expr_meta_xml_parse(struct nft_rule_expr *e, mxml_node_t *tr
meta->key = key;
e->flags |= (1 << NFT_EXPR_META_KEY);
+ reg = nft_mxml_reg_parse(tree, "dreg", MXML_DESCEND_FIRST);
+ if (reg >= 0) {
+ meta->dreg = reg;
+ e->flags |= (1 << NFT_EXPR_META_DREG);
+ } else {
+ reg = nft_mxml_reg_parse(tree, "sreg", MXML_DESCEND_FIRST);
+ if (reg < 0)
+ return -1;
+
+ meta->sreg = reg;
+ e->flags |= (1 << NFT_EXPR_META_SREG);
+ }
+
return 0;
#else
errno = EOPNOTSUPP;
@@ -225,23 +254,62 @@ static int nft_rule_expr_meta_xml_parse(struct nft_rule_expr *e, mxml_node_t *tr
}
static int
-nft_rule_expr_meta_snprintf(char *buf, size_t len, uint32_t type,
- uint32_t flags, struct nft_rule_expr *e)
+nft_rule_expr_meta_snprintf_default(char *buf, size_t len, uint32_t flags,
+ struct nft_rule_expr *e)
+{
+ struct nft_expr_meta *meta = nft_expr_data(e);
+
+ if (e->flags & (1 << NFT_EXPR_META_SREG))
+ return snprintf(buf, len, "set %s with reg %u ",
+ meta_key2str(meta->key), meta->sreg);
+
+ return snprintf(buf, len, "load %s => reg %u ",
+ meta_key2str(meta->key), meta->dreg);
+}
+
+static int
+nft_rule_expr_meta_snprintf_xml(char *buf, size_t len, uint32_t flags,
+ struct nft_rule_expr *e)
{
struct nft_expr_meta *meta = nft_expr_data(e);
+ if (e->flags & (1 << NFT_EXPR_META_SREG))
+ return snprintf(buf, len, "<key>%s</key><sreg>%u</sreg>",
+ meta_key2str(meta->key), meta->sreg);
+
+ return snprintf(buf, len, "<dreg>%u</dreg><key>%s</key>",
+ meta->dreg, meta_key2str(meta->key));
+}
+
+static int
+nft_rule_expr_meta_snprintf_json(char *buf, size_t len, uint32_t flags,
+ struct nft_rule_expr *e)
+{
+ struct nft_expr_meta *meta = nft_expr_data(e);
+
+ if (e->flags & (1 << NFT_EXPR_META_SREG))
+ return snprintf(buf, len, "\"key\":\"%s\","
+ "\"sreg\":%u",
+ meta_key2str(meta->key), meta->sreg);
+
+ return snprintf(buf, len, "\"dreg\":%u,\"key\":\"%s\"",
+ meta->dreg, meta_key2str(meta->key));
+}
+
+static int
+nft_rule_expr_meta_snprintf(char *buf, size_t len, uint32_t type,
+ uint32_t flags, struct nft_rule_expr *e)
+{
switch(type) {
case NFT_OUTPUT_DEFAULT:
- return snprintf(buf, len, "load %s => reg %u ",
- meta_key2str(meta->key), meta->dreg);
+ return nft_rule_expr_meta_snprintf_default(buf, len,
+ flags, e);
case NFT_OUTPUT_XML:
- return snprintf(buf, len, "<dreg>%u</dreg>"
- "<key>%s</key>",
- meta->dreg, meta_key2str(meta->key));
+ return nft_rule_expr_meta_snprintf_xml(buf, len,
+ flags, e);
case NFT_OUTPUT_JSON:
- return snprintf(buf, len, "\"dreg\":%u,"
- "\"key\":\"%s\"",
- meta->dreg, meta_key2str(meta->key));
+ return nft_rule_expr_meta_snprintf_json(buf, len,
+ flags, e);
default:
break;
}
diff --git a/tests/jsonfiles/65-rule-meta-target.json b/tests/jsonfiles/65-rule-meta-target.json
new file mode 100644
index 0000000..d058a1f
--- /dev/null
+++ b/tests/jsonfiles/65-rule-meta-target.json
@@ -0,0 +1 @@
+{"rule":{"family":"ip","table":"filter","chain":"output","handle":1,"expr":[{"type":"meta","key":"mark","sreg":1},{"type":"cmp","sreg":1,"op":"eq","cmpdata":{"data_reg":{"type":"value","len":4,"data0":"0x000003e8"}}},{"type":"counter","pkts":0,"bytes":0}]}}
diff --git a/tests/xmlfiles/76-rule-meta_target.xml b/tests/xmlfiles/76-rule-meta_target.xml
new file mode 100644
index 0000000..0c48ca5
--- /dev/null
+++ b/tests/xmlfiles/76-rule-meta_target.xml
@@ -0,0 +1 @@
+<rule><family>ip6</family><table>filter</table><chain>test</chain><handle>129</handle><expr type="meta"><key>mark</key><sreg>1</sreg></expr></rule>
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
