On Mon, Dec 02, 2013 at 09:55:49PM +0000, Christoph Lameter wrote:
> On Mon, 2 Dec 2013, Greg KH wrote:
>
> > > Signed-off-by: Christoph Lameter <cl@xxxxxxxxx>
> >
> > That looks good, if you fix the indentation issue :)
>
> Huh?
Your release function had 2 tabs for the lines, not one.
> > > Index: linux/include/linux/slub_def.h
> > > ===================================================================
> > > --- linux.orig/include/linux/slub_def.h 2013-12-02 13:31:07.395905824 -0600
> > > +++ linux/include/linux/slub_def.h 2013-12-02 13:31:07.385906101 -0600
> > > @@ -98,4 +98,8 @@ struct kmem_cache {
> > > struct kmem_cache_node *node[MAX_NUMNODES];
> > > };
> > >
> > > +#ifdef CONFIG_SYSFS
> > > +#define SLAB_SUPPORTS_SYSFS
> >
> > Why even define this? Why not just use CONFIG_SYSFS?
>
> Because not all slab allocators currently support SYSFS and there is the
> need to have different code now in slab_common.c depending on the
> configuration of the allocator.
But you are defining something that you only ever check once, why not
just use CONFIG_SYSFS instead as it makes more sense, not the other way
around.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
