Hello, On Mon, 2013-12-02 at 08:39 +0200, Tomasz Bursztyka wrote: > Hi Eric, > > > + > > +#define NFT_QUEUE_FLAG_BYPASS 0x01 /* for compatibility with v2 */ > > +#define NFT_QUEUE_FLAG_CPU_FANOUT 0x02 /* use current CPU (no hashing) */ > > +#define NFT_QUEUE_FLAG_MASK 0x03 > > Why not declaring them in an enum, as for nft_rule_compat_flags, > nft_set_flags or nft_set_elem_flags? Simple answer: It was not an enum in the original NFQUEUE code ;) Real answer: We have only two values, third one is a mask. So it may be a bit overkill to use an enum here. BR, -- Eric Leblond <eric@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html