[PATCH] src: expr: log: fixed error in nft_rule_expr_log_build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



If I run my automatic unit test of libnftable, It shows:
"ERROR: Expr NFT_EXPR_LOG_PREFIX mismatches"
a: test
b: test

The problem was in nft_rule_expr_log_build function.

With the attached patch, we use "mnl_attr_put_strz" in instead of
"mnl_attr_put_str".
---
 src/expr/log.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/expr/log.c b/src/expr/log.c
index 495c1bd..76657a9 100644
--- a/src/expr/log.c
+++ b/src/expr/log.c
@@ -119,7 +119,7 @@ nft_rule_expr_log_build(struct nlmsghdr *nlh, struct nft_rule_expr *e)
 	struct nft_expr_log *log = nft_expr_data(e);
 
 	if (e->flags & (1 << NFT_EXPR_LOG_PREFIX))
-		mnl_attr_put_str(nlh, NFTA_LOG_PREFIX, log->prefix);
+		mnl_attr_put_strz(nlh, NFTA_LOG_PREFIX, log->prefix);
 	if (e->flags & (1 << NFT_EXPR_LOG_GROUP))
 		mnl_attr_put_u16(nlh, NFTA_LOG_GROUP, htons(log->group));
 	if (e->flags & (1 << NFT_EXPR_LOG_SNAPLEN))
-- 
1.8.4.rc3

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux