On Fri, 2013-11-15 at 15:57 +0100, Jesper Dangaard Brouer wrote: > Reorder struct netns_ct so that atomic_t "count" changes don't > slowdown users of read mostly fields. > > This is based on Eric Dumazet's proposed patch: > "netfilter: conntrack: remove the central spinlock" > http://thread.gmane.org/gmane.linux.network/268758/focus=47306 > > The tricky part of cache-aligning this structure, that it is getting > inlined in struct net (include/net/net_namespace.h), thus changes to > other netns_xxx structures affects our alignment. > > Eric's original patch contained an ambiguity on 32-bit regarding > alignment in struct net. This patch also takes 32-bit into account, > and in case of changed (struct net) alignment sysctl_xxx entries have > been ordered according to how often they are accessed. > > Signed-off-by: Jesper Dangaard Brouer <brouer@xxxxxxxxxx> > Reviewed-by: Jiri Benc <jbenc@xxxxxxxxxx> > --- > Yes, I know it's not the time to submit this patch, but > I just want to let Eric know that I'm planning on extracting > part of his proposed patch, which have been stalled for months. > I'll resubmit once net-next/nf-next opens for changes again. I have no plan working on conntrack in the near future. I cannot really cope with a 3 months response time to a patch. Feel free to grab and continue the work, thanks ! -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
