Re: [PATCH] netfilter: Fix the format of /proc/net/nf_conntrack_expect

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 12, 2013 at 11:08:06PM +0800, Changli Gao wrote:
> There should not be any white space around `='.
>
> ---
>  net/netfilter/nf_conntrack_expect.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/netfilter/nf_conntrack_expect.c b/net/netfilter/nf_conntrack_expect.c
> index 4fd1ca9..151af72 100644
> --- a/net/netfilter/nf_conntrack_expect.c
> +++ b/net/netfilter/nf_conntrack_expect.c
> @@ -517,7 +517,7 @@ static int exp_seq_show(struct seq_file *s, void *v)
>  			   ? (long)(expect->timeout.expires - jiffies)/HZ : 0);
>  	else
>  		seq_printf(s, "- ");
> -	seq_printf(s, "l3proto = %u proto=%u ",
> +	seq_printf(s, "l3proto=%u proto=%u ",

Yes, that doesn't look nice, but that output format is there since
2006 (introduced in 77ab9cff).

This is a legacy interface (we have ctnetlink and the conntrack
utility these days) and I don't want to break backward for
applications parsing that output. I'm not taking this.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux