Re: [PATCH 2/3] ipset: Fix malformed output from list/save for ICMP types in port field.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 7 Nov 2013, Sergey Popovich wrote:

> Found with ipset 6.12.1, but upstream version is still affected.
> 
> Creating set of dimension three, adding elements to it and then
> displaying gives following results:
> -----------------------------------
> 
>  # ipset create test-1 hash:ip,port,ip
>  # ipset add test-1 192.0.2.1,icmp:echo-request,192.0.2.1
>  # ipset add test-1 192.0.2.1,icmp:ttl-zero-during-reassembly,192.0.2.1
>  # ipset list test-1
>  Name: test-1
>  Type: hash:ip,port,ip
>  Header: family inet hashsize 1024 maxelem 65536
>  Size in memory: 16608
>  References: 0
>  Members:
>  192.0.2.1,icmp:ttl-zero-during-reass,192.0.2.1
>  192.0.2.1,icmp:echo-re,192.0.2.1
> 
> Same results with -output save|xml.
> 
> ipset_print_proto_port() from lib/print.c returns incorrect length
> of printed string when ICMP/ICMPv6 specified in port field.

Patch is applied, thanks.

Best regards,
Jozsef
-
E-mail  : kadlec@xxxxxxxxxxxxxxxxx, kadlecsik.jozsef@xxxxxxxxxxxxx
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux