Fri, Nov 08, 2013 at 12:54:53AM CET, davem@xxxxxxxxxxxxx wrote: >From: Jiri Pirko <jiri@xxxxxxxxxxx> >Date: Wed, 6 Nov 2013 17:52:19 +0100 > >> If reassembled packet would fit into outdev MTU, it is not fragmented >> according the original frag size and it is send as single big packet. >> >> The second case is if skb is gso. In that case fragmentation does not happen >> according to the original frag size. >> >> This patch fixes these. >> >> Signed-off-by: Jiri Pirko <jiri@xxxxxxxxxxx> > ... > >> if ((skb->len > ip6_skb_dst_mtu(skb) && !skb_is_gso(skb)) || >> - dst_allfrag(skb_dst(skb))) >> + dst_allfrag(skb_dst(skb)) || >> + (IP6CB(skb)->frag_max_size && skb->len > IP6CB(skb)->frag_max_size)) >> return ip6_fragment(skb, ip6_finish_output2); > >Jiri are you sure that you don't need to take GSO into account in the >new part you are adding to the test? For gso skb, we need co cap outgoing fragments by the original frag size as well. So I believe that this code is correct for that case as well. >-- >To unsubscribe from this list: send the line "unsubscribe netdev" in >the body of a message to majordomo@xxxxxxxxxxxxxxx >More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
