On Tue, Oct 08, 2013 at 12:16:09PM +0300, Tomasz Bursztyka wrote: > Hi Pablo, > >+ /* Default on AF_INET */ > >+ h->ops = nft_family_ops_lookup(AF_INET); > >+ if (h->ops == NULL) > >+ xtables_error(PARAMETER_PROBLEM, "Unknown family"); > >+ > > Since you use AF_INET by default... If neither -4 and -6 is passed, we assume AF_INET. > > opts = xt_params->orig_opts; > > while ((cs.c = getopt_long(argc, argv, > > "-:A:C:D:R:I:L::S::M:F::Z::N:X::E:P:Vh::o:p:s:d:j:i:fbvnt:m:xc:g:46", > >@@ -894,6 +899,9 @@ int do_commandx(struct nft_handle *h, int argc, char *argv[], char **table) > > if (args.proto == 0 && (args.invflags & XT_INV_PROTO)) > > xtables_error(PARAMETER_PROBLEM, > > "rule would never match protocol"); > >+ > >+ /* This needs to happen here to parse extensions */ > >+ h->ops->proto_parse(&cs, &args); > > break; > > case 's': > >@@ -1033,11 +1041,21 @@ int do_commandx(struct nft_handle *h, int argc, char *argv[], char **table) > > case '4': > > if (args.family != AF_INET) > > exit_tryhelp(2); > >+ > >+ h->ops = nft_family_ops_lookup(args.family); > >+ if (h->ops == NULL) > >+ xtables_error(PARAMETER_PROBLEM, > >+ "Unknown family"); > > ... this is useless I guess, then. Yes, copied and pasted from the original code, will remove it. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
