Re: [iptables-nftables PATCH 0/3] NFPROTO_ARP and arp mangle target support (+ one minor fix)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 03, 2013 at 11:26:19AM +0300, Tomasz Bursztyka wrote:
> Hi,
> 
> @Pablo: I understand that patch 2 is not necessary, but what about
> patch 3? This one is relevant to get xtables-arp being able to
> handle mangle target.
> Or is there any issue with it?

Please, rename it to libxt_mangle.c and restrict its usage to the
NFPROTO_ARP family. With this change, I think we can skip patch 2, I'm
reticent to bloat our build system to support libarp_ prefix, it's
just one single extension after all.

Let me know if you have any issue, thanks.

> >This patchset prepares for arptables-nftables to be included so it will use libxtables for its target.
> >
> >Tomasz Bursztyka (3):
> >   nft: Fix a minor compilation warning
> >   libxtables: Add NFPROTO_ARP support for libarpt_* prefixed extensions
> >   libxtables: Port libarptc mangle target into libxtables
> >
> >  configure.ac                              |   5 +
> >  extensions/GNUmakefile.in                 |  52 +++-
> >  extensions/libarpt_mangle.c               | 388 ++++++++++++++++++++++++++++++
> >  include/linux/netfilter_arp.h             |  19 ++
> >  include/linux/netfilter_arp/arp_tables.h  | 204 ++++++++++++++++
> >  include/linux/netfilter_arp/arpt_mangle.h |  26 ++
> >  iptables/nft-shared.c                     |   2 +-
> >  libxtables/xtables.c                      |  14 ++
> >  8 files changed, 701 insertions(+), 9 deletions(-)
> >  create mode 100644 extensions/libarpt_mangle.c
> >  create mode 100644 include/linux/netfilter_arp.h
> >  create mode 100644 include/linux/netfilter_arp/arp_tables.h
> >  create mode 100644 include/linux/netfilter_arp/arpt_mangle.h
> >
> 
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux