> Thanks Holger, I wanted to do the same for a long time now. It actually
> also fixes a minor race condition, when the NAT helper is loaded or
> unloaded while a packet is processed the hooks may be invoked only
> partially.
>
> Just one request:
>
> > +struct nf_nat_sip_hooks {
> > + unsigned int (* nsh_msg)(struct sk_buff *skb,
> > + unsigned int protoff,
> > + unsigned int dataoff,
> > + const char **dptr,
> > + unsigned int *datalen);
>
> I really hate unpronouncable abbrevations, it hurts my eyes and IMO makes
> it harder to read the code. Please use something nicer or get rid of the
> prefix entirely.
Ok, I'll remove the prefix then.
However, personally I think they help grep'ing a lot, like e. g. the
ndo_ prefix with netdevice ops (still usefull even as a 'cscope'
user).
Also the function names are *shorter* with the patch, as I was able
to remove the nf_nat_ prefix.
/Holger
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
