You're right. Withdrawn.
On Fri, Sep 6, 2013 at 8:49 PM, Jan Engelhardt <jengelh@xxxxxxx> wrote:
>
> On Friday 2013-09-06 23:39, Laurence J. Lane wrote:
>
>>Fixes dangling symlinks when using DESTDIR.
>>
>>Signed-off-by: Laurence J. Lane <ljlane@xxxxxxxxxx>
>>- for i in ${vx_bin_links}; do ${LN_S} -f \
>> "${sbindir}/xtables-multi" "${DESTDIR}${bindir}/$$i"; done;
>>+ for i in ${vx_bin_links}; do ${LN_S} -f \
>> "${DESTDIR}${sbindir}/xtables-multi" "${DESTDIR}${bindir}/$$i"; done;
>
> This seems totally incorrect. By including DESTDIR in the symlink
> target, you are *creating* a dangling symlink. RPM, DEB (and whatever
> other packages) would suddenly contain a file that goes like
>
> $ rpm -ql iptables
> lrwxrwxrwx 1 root root 13 Jan 27 2013 /usr/sbin/iptables ->
> /home/abuild/rpmbuild/BUILDROOT/iptables-1.4.20/usr/bin/xtables-multi
>
> !DSPAM:522a78438821787114786!
>
>
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
