Re: [PATCH 2/4] libnetfilter-acct: Introduce support for notifications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Pablo,

On 09/04/2013 02:44 PM, Pablo Neira Ayuso wrote:
On Wed, Sep 04, 2013 at 02:05:31PM +0200,valentina.giusti@xxxxxxxxxxxx  wrote:

<snip>

  #define NFACCT_MAX (__NFACCT_MAX - 1)
diff --git a/src/libnetfilter_acct.c b/src/libnetfilter_acct.c
index ba89e2d..4fb0d26 100644
--- a/src/libnetfilter_acct.c
+++ b/src/libnetfilter_acct.c
@@ -60,6 +60,11 @@ struct nfacct {
  	char		name[NFACCT_NAME_MAX];
  	uint64_t	pkts;
  	uint64_t	bytes;
+	uint32_t	notify_pkts;
+	uint32_t	notify_pkts_rl;
+	uint32_t	notify_bytes;
+	uint32_t	notify_bytes_rl;
+	uint32_t	notify_period;
This is bloating the nfacct object for everyone in the earth not using
this notification infrastructure.

Right... I'll replace this with a pointer to another structure. Do you suggest that I also #ifdef everything?

Thank you.

-V.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux