Re: [PATCH lnf-queue] build: avoid sym namespace pollution

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 13, 2013 at 10:48:50AM +0200, Florian Westphal wrote:
> as of f40eabb01 (add pkt_buff and protocol helper functions)
> lnetfilter_queue exports a function named 'checksum'.  This is a bit
> too generic and causes crash with applications that worked fine before.

I see, that was not the intention as they are supposed to be internal
(as you can see in src/internal.h), however, it seems that the
visibility changes were incomplete, sorry.

> This patch makes the functions checksum, checksum_tcpudp_ipv4 and
> checksum_tcpudp_ipv6 local by building with fvis-hidden and adding
> EXPORTs for the legacy api calls and the ones that seem to have missing
> EXPORT tags (mainly pktbuf api).

I have applied this, thanks Florian.

> Signed-off-by: Florian Westphal <fw@xxxxxxxxx>
> ---
>  Alternative would be to rename "checksum" to something

I have just renamed those, even if they are internal I think it's a
good cleanup.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux