Re: [PATCH 3/5] netfilter: nf_nat: fix locking in nf_nat_seq_adjust()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 31, 2013 at 06:55:23PM +0200, Pablo Neira Ayuso wrote:
> On Sun, Jul 28, 2013 at 10:54:09PM +0200, Patrick McHardy wrote:
> > nf_nat_seq_adjust() needs to grab nf_nat_setofs_lock to protect against
> > concurrent changes to the sequence adjustment data.
> 
> Applied, thanks.
> 
> I have enqueued this to nf so it hits 3.11. I have to wait to take 4/5
> and 5/5 for a while until this patch hits Linus tree.

We've had this problem since the beginning of netfilter, so I think
this can go to -next. So far I haven't seen any bugreports related to
this, but its clearly wrong.

A follow up patch will move the entire sequence number adjustment data
to an extend, so the size increase will only affect the quite rare case
of connections using a helper.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux