On Fri, Jul 26, 2013 at 01:05:15PM +0200, Giuseppe Longo wrote: > The following patch adds own builtin_table pointer used by future tool (like arptables) > to have own tables and not tables declared in nft.c If I apply this patch and if I type 'make', it says: nft.c: In function ‘nft_table_builtin_find’: nft.c:297:7: error: ‘tables’ undeclared (first use in this function) nft.c:297:7: note: each undeclared identifier is reported only once for each function it appears in nft.c:297:7: warning: left-hand operand of comma expression has no effect [-Wunused-value] nft.c:297:7: warning: value computed is not used [-Wunused-value] nft.c:297:7: warning: left-hand operand of comma expression has no effect [-Wunused-value] mv -f .deps/xtables_multi-iptables.Tpo .deps/xtables_multi-iptables.Po mv -f .deps/xtables_multi-xtables-config-parser.Tpo .deps/xtables_multi-xtables-config-parser.Po nft.c:305:1: warning: control reaches end of non-void function [-Wreturn-type] make[2]: *** [xtables_multi-nft.o] Error 1 Patches have to leave the repository in a consistency state, ie. compilation/operational should not break between patches, at least not voluntarily. This usually means that you're incorrectly splitting the patches. I have merged 1/5 and 2/5 into one single patch and push it into master. Thanks Giuseppe. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
