On Tue, 2013-07-16 at 17:24 +0400, Sergei Shtylyov wrote: > > + skb->transport_header = skb->network_header + iph->ihl*4; > > Spaces around * wouldn't hurt, to be consistent with the rest of the > statement and the Linux style in common. I am well aware of this, I chose the convention used in this function and file. # grep ihl net/ipv4/ip_input.c opt->optlen = iph->ihl*4 - sizeof(struct iphdr); if (iph->ihl > 5 && ip_rcv_options(skb)) if (iph->ihl < 5 || iph->version != 4) if (!pskb_may_pull(skb, iph->ihl*4)) if (unlikely(ip_fast_csum((u8 *)iph, iph->ihl))) } else if (len < (iph->ihl*4)) Thanks -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
