On Fri, 5 Jul 2013, Dash Four wrote: > Jozsef Kadlecsik wrote: > > I have just noticed one single issue with your patches: the revision bumping > > for the set types are missing. > > > Interesting. I wasn't aware you've introduced this feature and by > looking at the logs, this has been present since 6.14 - shame on me for > not noticing it. > > > So please extend the second patch with the type revisions incremented (have > > a look at the hash:net type how the revision comments are kept) > > and add a userspace patch with the revisions bumped in userspace too (it's > > fine to copy the most recent ones and increase the revisions, adjust the > > descriptions). > In other words, something like: > > kernel/net/netfilter/ip_set_*.c > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > -#define IPSET_TYPE_REV_MAX 3 /* Counters support added */ > +/* 3 Counters support added */ > +#define IPSET_TYPE_REV_MAX 4 /* Inner flag support added */ > > lib/ipset_*.c > ~~~~~~~~~~~~~ > copy the entire ipset_hash_netX struct, bump the ".revision" and adjust the > ".description" fields? > > Would that suffice? Yes, exactly. > Also, would you like me to modify my 3rd patch (which is where I've made > the changes to all sets - in patch two I reimplemented the "internal" > functions) and issue a separate one for all lib/ipset_*.c changes or > would you like me to reissue the whole set of patches (1-6)? I meant the third patch, but wrote "second" above.... You can reissue just the third and send the new sixth for lib/ipset_*.c. Best regards, Jozsef - E-mail : kadlec@xxxxxxxxxxxxxxxxx, kadlecsik.jozsef@xxxxxxxxxxxxx PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences H-1525 Budapest 114, POB. 49, Hungary -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
