Re: [PATCH v2 2/5] ipset: add "inner" flag implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 29 Jun 2013, Dash Four wrote:

> > > By including "goto err" instead of multiple "return false" statement, that
> > > makes it instantly obvious what the purpose of that statement is without
> > > having to look elsewhere. 
> > 
> > I see the point, to self-document the code, with the price of more lines.
> > It's a little bit overdoing in my opinion: pretty apparent which is the
> > error path and which is not. But this is highly a personal taste, I won't
> > press it.
> >   
> In other words, you'll be happy for me to leave things as they are - 
> with the "goto"?

I won't be happy but I can stomach it. So you can leave the gotos there as
you are conviced those add a readability value.

Best regards,
Jozsef
-
E-mail  : kadlec@xxxxxxxxxxxxxxxxx, kadlecsik.jozsef@xxxxxxxxxxxxx
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux