Re: [PATCH v3 1/2] iptables-nftables: function nft_chain_zero_counters added.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Giuseppe,

I guess you don't want to continue looping after you found your chain. On
success, make it break.
Looking the code, in other functions like nft_chain_user_del,
i guess that the loop continue after found the chain.
Am i wrong?

Looks like you found an optimization patch to make in that function.

And on error your function should return the error code.
return ret == 0 ? 1 : 0;
is it ok this code?


Sound fine to me in that particular case.


Tomasz

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux