On Mon, Jun 17, 2013 at 01:13:08PM +0300, Tomasz Bursztyka wrote:
> Hi Giuseppe,
>
> Minor comments below.
>
> >+
> >+ nlh = nft_chain_nlmsg_build_hdr(buf, NFT_MSG_NEWCHAIN, h->family,
>
> This line seems to have more than 80 characters.
>
> There is a script in linux kernel sources that might help you before
> sending any patches: scripts/checkpatch.pl
> Run it against your patches, it will tell you about such style
> issues. At least at the beginning, at some point code style becomes
> a reflex.
>
>
> >+ NLM_F_ACK, h->seq);
> >+
> >+ nft_chain_nlmsg_build_payload(nlh, c);
> >+
> >+ ret = mnl_talk(h, nlh, NULL, NULL);
> >+ if (ret < 0)
> >+ perror("mnl_talk:nft_chain_zero_counters");
>
> I guess you don't want to continue looping after you found your
> chain. On success, make it break.
>
> And on error your function should return the error code.
While at it, please also merge patch 1/2 and 2/2, we need that the
repository remains consistent across updates. Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
