Re: [libnftables PATCH 3/4] Add JSON Constant for to use the Json export function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Alvaro,

On Thu, Jun 06, 2013 at 03:17:25PM +0200, Alvaro Neira wrote:
> 
> ---
>  0 files changed
> 
> diff --git a/include/libnftables/table.h b/include/libnftables/table.h
> index 658230c..19f322c 100644
> --- a/include/libnftables/table.h
> +++ b/include/libnftables/table.h
> @@ -31,6 +31,7 @@ void nft_table_nlmsg_build_payload(struct nlmsghdr *nlh, const struct nft_table
>  enum {
>  	NFT_TABLE_O_DEFAULT	= 0,
>  	NFT_TABLE_O_XML,
> +	NFT_TABLE_O_JSON,

you have to collapse patch 1/4, 3/4 and 4/4. You cannot add the
definition of this constant in a follow-up patch. Note that the
repository has to remain consistent between patches, and after patch
1/4, if I compile libnftables, it would break.

Please, fix it and resubmit. Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux