Re: [PATCH 3/3] expect: consider all expect attributes when comparing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> On Wed, Jun 05, 2013 at 05:41:01PM +0200, Florian Westphal wrote:
> > Hrm, I think a better option is to not compare the expectation timeout
> > in the first place.  I think the timeout is an irrelevant meta detail;
> > if the actual expectations are identical, nfexp_cmp should say so even
> > if they happen to have different timeouts.
> 
> That's fine with me, we don't have any requirement for such feature at
> this moment. So just skip it. Probably adding a short comment in the
> code would be a good idea as placeholder.

Perfect!
I've pushed all three patches, with ATTR_TIMEOUT compare replaced by a
comment. 
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux