Re: [PATCH v2 nf-next] netfilter: conntrack: remove the central spinlock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Joe Perches <joe@xxxxxxxxxxx>
Date: Wed, 22 May 2013 14:12:51 -0700

> @@ -528,7 +528,7 @@ struct netdev_queue {
>   * write mostly part
>   */
>  	spinlock_t		_xmit_lock ____cacheline_aligned_in_smp;
> -	int			xmit_lock_owner;
> +	u16			xmit_lock_owner;
>  	/*
>  	 * please use this field instead of dev->trans_start
>  	 */
> @@ -2453,7 +2453,7 @@ static inline void __netif_tx_unlock_bh(struct netdev_queue *txq)
>  
>  static inline void txq_trans_update(struct netdev_queue *txq)
>  {
> -	if (txq->xmit_lock_owner != -1)
> +	if (txq->xmit_lock_owner != (u16)-1)
>  		txq->trans_start = jiffies;
>  }

Then technically this is an s16, don't use casts to pretend that it
isn't.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux