Hi Eric, On Sun, May 12, 2013 at 12:29:29PM +0200, Eric Leblond wrote: > Le samedi 11 mai 2013 à 21:29 +0200, Pablo Neira Ayuso a écrit : > > On Fri, May 10, 2013 at 08:48:56AM +0200, Eric Leblond wrote: > > > This patch adds an optional ring buffer option which modify > > > the way database queries are made. The main thread is only handling > > > kernel message reading and query formatting. The SQL request is made > > > in a separate dedicated thread. > > > The idea is to try to avoid buffer overrun by minimizing the time > > > requested to treat kernel message. Doing synchronous SQL request, as > > > it was made before was causing a delay which could cause some messages > > > to be lost in case of burst from kernel side. > > > > Would be feasible to make asynchronous SQL requests instead, so you > > can skip the use of pthread? [...] > From a lazy point of view, this would require to update all the database > backends instead of simply updating the db abstraction layer as it is > done with the proposed patch. Fair enough, it provides a generic way to support this and the main thread should be really taking care of netlink messages coming from the kernel to avoid the overrun. If the target is to overcome small bursts, this should help to relief those peaks for some time, but at some point the intermediate queue (the ring) will also get full if the situation lasts long. Regards. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
