Re: [PATCH] ipset: Fix syntax error of bash completion in Debian environment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On Thu, May 16, 2013 at 2:24 AM, Bourne Without <blackhole@xxxxxxxxxxx> wrote:
> On 12.05.2013 14:07, Neutron Soutmun wrote:
>>
>> Cc-d script's author
>>
>
> Hello,
>
> thanks for reporting.
>
>
>> On Sun, May 12, 2013 at 4:28 PM, Neutron Soutmun <neo.neutron@xxxxxxxxx>
>> wrote:
>>>
>>> Debian packaging tool (lintian) warns the syntax error of bash completion
>>> as it uses the extglob shell option that should be run in
>>> the ** #!/usr/bin/env bash ** and the shell option set should be moved to
>>> global scope.
>>>
>>> Signed-off-by: Neutron Soutmun <neo.neutron@xxxxxxxxx>
>>> ---
>>>   utils/ipset_bash_completion/ipset_bash_completion |    5 +++--
>>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/utils/ipset_bash_completion/ipset_bash_completion
>>> b/utils/ipset_bash_completion/ipset_bash_completion
>>> index cc7ea7b..8a0b91d 100644
>>> --- a/utils/ipset_bash_completion/ipset_bash_completion
>>> +++ b/utils/ipset_bash_completion/ipset_bash_completion
>>> @@ -1,4 +1,4 @@
>>> -#!/bin/bash
>>> +#!/usr/bin/env bash
>
>
> Actually I think the shebang isn't required at all.
> Does the debian tool just warn?

Sorry for the noise, I just search the BTS and found this
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=699410

It seems to be the false positive of lintian.
However, the #!/usr/bin/env bash is the workaround for this issue :)

Thanks for your kindness to review it.

Best regards,
Neutron Soutmun
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux