Re: [PATCH] netfilter: log: netns NULL ptr bug when calling from conntrack.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Pablo,

On Wed, 2013-05-15 at 14:00 +0200, Pablo Neira Ayuso wrote:
> Hi Hans,
> 
> On Wed, May 15, 2013 at 01:23:45PM +0200, Hans Schillstrom wrote:
> > When callling log functions from conntrack both in and out
> > is NULL i.e. there exist no net pointer.
> > 
> > Adding struct net *net in call to nf_logfn() will secure that
> > there always is a vaild net ptr.
> > 
> > Reported as bugzilla bug 818
> 
> This approach to fix it looks good. Thanks a lot!
> 
> Just resolved a minor nitpick:
[snip]
..
> >  
> >  static void
> > -ebt_log_packet(u_int8_t pf, unsigned int hooknum,
> > +ebt_log_packet(struct net *net, int8_t pf, unsigned int hooknum,
> 
> pf still has to be u_int8_t so I don't hit a compilation warning. No
> need to resent I fixed it here.

Thanks, 
I must have pressed "del" to hard :-)


Attachment: smime.p7s
Description: S/MIME cryptographic signature


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux