On Fri, Apr 19, 2013 at 04:58:25PM +0200, Florian Westphal wrote: > There is nothing wrong with the current code. > > However, skb_gso_segment is expensive, so it would be nice > if we could avoid it in the future. > > Since userspace must be prepared to receive larger-than-mtu-packets > (which will also have incorrect l3/l4 checksums), we cannot simply > remove it. > > The plan is to add a per-queue feature flag that userspace can > set when binding the queue. > > The problem is that in nf_queue, we only have a queue number, > not the queue context/configuration settings. > > This patch should have no impact other than the skb_gso_segment > call now being in a function that has access to the queue config data. > > The size new size attribute in nf_queue_entry is needed so > nfnetlink_queue can duplicate the entry of the gso skb > when segmenting the skb while also copying the route key. > > Next step: avoid skb_gso_segment when queue config says so. Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
