Re: [libnftables PATCH v2] Basic support for printing nft_data_reg in XML format.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 09, 2013 at 10:26:48PM +0200, Arturo Borrero Gonzalez wrote:
> 2013/4/9 Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>:
> >
> > Cannot use "data" instead of immediate data? This is nested in
> > <immediate>...</immediate>, it seems redundant to me.
> 
> Understood. And I will fix it.
> 
> But let me explain why I did it:
> 
> for example, cmp is using <cmpdata>
> <cmpdata> has <data_reg></data_reg> which can also be redundant.
> 
> But all around the XML printing (including sets, an incoming patch)
> i've been nesting the data_reg into another XML node, so you could
> easily see (also the XML parser) the difference between (for example.
> in set) nft_set_elem->key and nft_set_elem->data.
> As I needed to nest in nft_set_elem I decided to follow a constant
> line and do nest all data_reg.

Fair enough. I have applied this patch.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux