Hi David, On Tue, Apr 16, 2013 at 07:27:25PM +0100, David Howells wrote: > This is only needed by the xt_hashlimit netfilter module as that appears to > use the name in the pde to save a label in the xt_hashlimit_htable struct - > which will be a problem if CONFIG_PROC_FS=n. I don't know the larger context of this patch (and am not follwing filesystem related work in general), but at least from the xt_hashlimit point of view this of course looks fine. We can always wrap direct accesses to structure members behind an API call. For consistency reasons 'proc_get_name()' might be a better name than get_proc_name(), but that's probably a matter of taste. Pleaes note that I'm only the original author but not the active maintainer of the xt_hashlimit (formerly ipt_hashlimit) code. Regards, Harald -- - Harald Welte <laforge@xxxxxxxxxxxxx> http://netfilter.org/ ============================================================================ "Fragmentation is like classful addressing -- an interesting early architectural error that shows how much experimentation was going on while IP was being designed." -- Paul Vixie -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
