Re: [Ulogd2 PATCH 1/3] Remove configure check for libmnl, it is not used

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/05/2013 05:34 PM, Pablo Neira Ayuso wrote:
> On Fri, Apr 05, 2013 at 04:33:55PM +0200, Victor Julien wrote:
>> If libmnl is missing configure fails. However, the lib is not used nor
>> linked to.
>>
>> ---
>>  configure.ac |    1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index c94704b..a439bee 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -49,7 +49,6 @@ AC_SUBST([regular_CFLAGS])
>>  
>>  dnl Check for the right nfnetlink version
>>  PKG_CHECK_MODULES([LIBNFNETLINK], [libnfnetlink >= 1.0.1])
>> -PKG_CHECK_MODULES([LIBMNL], [libmnl >= 1.0.3])
> 
> input/sum/ulogd_inpflow_NFACCT.c
> 
> needs this.

Shouldn't it be a conditional check then? Only if nfacct is enabled?

I'm testing with only nflog support and it builds and runs fine with my
patch.

-- 
---------------------------------------------
Victor Julien
http://www.inliniac.net/
PGP: http://www.inliniac.net/victorjulien.asc
---------------------------------------------

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux