On Tue, Feb 05, 2013 at 04:30:07AM +0100, Pablo Neira Ayuso wrote: > On Mon, Jan 28, 2013 at 02:59:41PM +0100, Jan Engelhardt wrote: > > The just-built library has DT_RPATH entries to be runnable from > > whereever it is. If we just install that, the distro build systems > > will throw warnings like > > > > (Open Build Service) ERROR: RPATH > > "/home/abuild/rpmbuild/BUILD/iptables-1.4.17a/libxtables/.libs" > > on /home/abuild/rpmbuild/BUILDROOT/iptables-1.4.17a-0.x86_64/usr/lib64/xtables/libxt_unclean.so > > is not allowed > > > > These RPATH entries are indeed undesired for libraries is in a system > > location, which is why libtool produces another copy of the library on > > installation. The makefile however missed using libtool during > > installation (introduced with commit v1.4.17-1-g68e77a2). > > This patch now resolves this. > > > > There will be extra "warnings" emitted by libtool during `make install`, > > like: > > > > libtool: install: warning: relinking "libxt_AUDIT.la" > > > > This is normal (and unfixable) > > I prefer that distros live with that warning. Users will be annoyed by > that warning for sure. There is a clear misunderstanding on your side, a RPATH entry containing buildroot is a FATAL ERROR that distro maintainers have to fix just to release new builds of iptables package. The question is how long distro maintainers would have to reinvent the wheel and rebase these build fixes onto new iptables releases. To be honest, I was much surprised to find out that these build fixes didn't get into 1.4.18. With regards to libtool's warnings about relinking, it happens to all hundreds of packages that manipulate RPATH entries during build, so the amount of annoyance among libtool users would hardly increase. -- ldv
Attachment:
pgpr6hsaUPa_o.pgp
Description: PGP signature
