On Tue, 2013-02-19 at 02:11 +0100, Pablo Neira Ayuso wrote:
> On Mon, Feb 18, 2013 at 04:22:02PM -0800, Joe Perches wrote:
> > On Tue, 2013-02-19 at 01:10 +0100, pablo@xxxxxxxxxxxxx wrote:
> > > This patch modifies the existing code to provide more specific
> > > error message in the scope of each helper to help users to debug
> > > the reason why the packet has been dropped, ie:
> > []
> > > diff --git a/include/net/netfilter/nf_conntrack_helper.h b/include/net/netfilter/nf_conntrack_helper.h
> > []
> > > @@ -100,6 +100,9 @@ struct nf_ct_helper_expectfn {
> > > void (*expectfn)(struct nf_conn *ct, struct nf_conntrack_expect *exp);
> > > };
> > >
> > > +extern void nf_ct_helper_log(struct sk_buff *skb, const struct nf_conn *,
> > > + const char *fmt, ...);
> >
> > this should be declared
> >
> > __printf(3, 4)
> > void nf_ct_helper_log(etc...)
>
> Fixed, thanks.
Well, not really.
The new prototype is:
+extern __printf(3,4) void nf_ct_helper_log(struct sk_buff *skb,
+ const struct nf_conn *,
+ const char *fmt, ...);
+
The extern isn't necessary.
The second arg doesn't have a name.
The printf args could use a space between them.
I think this should be
__printf(3, 4)
void nf_ct_helper_log(struct sk_buff *skb, const struct nf_conn *ct,
const char *fmt, ...);
without the extern to be more like the prototypes that follow
it in that file.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
