Hi.
I was about to push the pending connlabel patches
for libnetfilter_conntrack, but then noticed one important
point, namely, handling of ATTR_CONNLABEL with nfct_set_attr().
The existing setters all copy their argument, but the current connlabel
setter only assigns the pointer, i.e., 'ownership' of the bitmask object
is then tied to conntrack object. This may not be whats expected.
Should I make this change:
set_attr_connlabels(struct nf_conntrack *ct, const void *value, size_t len)
{
- ct->connlabels = (void *) value;
+ ct->connlabels = nfct_bitmask_clone(value);
}
to avoid this or not?
If noone objects, I will make this modifcation and push into -next branch.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
