Jean-Michel DILLY <jm@xxxxxxxx> wrote: > Hi all, > This patch doesn't work as expected. I tried with few IP and each time 0x0100 were missing. csum_add seems buggy too. > I have reimplemented csum16s functions with the Ulrich's fix. It seems to work now. > I'm a noob, so I guess someone will propose a better patch for this. We can't use csum_add after all, patch looks correct. Can you re-send with proper Signoff? [ carry detection breaks on overflow, e.g. a==1 and b=0xffff yields 0 for csum_add (65536 < 1) and 1 for csum16_add (0 < 1) ] -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
