Re: [PATCH] build: resolve link failure for ip6t_NETMAP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday 31 December 2012 00:54:06 Jan Engelhardt wrote:
> Like this? We cannot really get rid of mentioning .libs without involving
> libltdl, and there I really do not want to go.

why ?  are the modules run directly out of the build tree, or you just need to 
install them ?  `libtool --mode=install` can install an .la file ...

> +	${AM_VERBOSE_NULL} ln -fs .libs/$@ $@;

i'm not sure why a lot of these rules have trailing semi-colons.  they're 
pointless.

> +	${AM_VERBOSE_CCLD} ../libtool ${AM_LIBTOOL_SILENT} --tag=CC --mode=link
> ${CCLD} ${AM_LDFLAGS} -module ${LDFLAGS} -o $@ $< -L../libxtables
> -lxtables ${$*_LIBADD} -rpath ${xtlibdir};

should be ../libxtables/libxtables.la rather than -L/-l for libxtables

>  libxt_NOTRACK.so: libxt_CT.so
>  	ln -fs $< $@
> libxt_state.so: libxt_conntrack.so
>  	ln -fs $< $@

these two rules could use your new $AM_VERBOSE_NULL

otherwise, this is an improvement imo over the existing code
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux