Re: [libnetfilter_conntrack PATCH] Fix logic typo in cmp_secctx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thomas Jarosch <thomas.jarosch@xxxxxxxxxxxxx> wrote:
> cppcheck reported:
> [src/conntrack/compare.c:364] -> [src/conntrack/compare.c:364]: (style) Same expression on both sides of '||'.
> 
> Signed-off-by: Thomas Jarosch <thomas.jarosch@xxxxxxxxxxxxx>
> ---
>  src/conntrack/compare.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/conntrack/compare.c b/src/conntrack/compare.c
> index b18f7fc..e282a24 100644
> --- a/src/conntrack/compare.c
> +++ b/src/conntrack/compare.c
> @@ -361,7 +361,7 @@ cmp_secctx(const struct nf_conntrack *ct1,
>  	   const struct nf_conntrack *ct2,
>  	   unsigned int flags)
>  {
> -	if (ct1->secctx == NULL || ct1->secctx == NULL)
> +	if (ct1->secctx == NULL || ct2->secctx == NULL)

Grrr, my fault.

Applied, thanks for fixing this.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux