On Mon, Dec 03, 2012 at 01:50:36PM +0100, Pablo Neira Ayuso wrote: > On Mon, Dec 03, 2012 at 12:06:10PM +0100, Florian Westphal wrote: > > pablo@xxxxxxxxxxxxx <pablo@xxxxxxxxxxxxx> wrote: > > > > Hi Pablo, > > > > I have one question related to ct object destruction: > > > > > @@ -247,6 +245,9 @@ void nf_ct_delete_from_lists(struct nf_conn *ct) > > > * Otherwise we can get spurious warnings. */ > > > NF_CT_STAT_INC(net, delete_list); > > > clean_from_lists(ct); > > > + /* add this conntrack to the dying list */ > > > + hlist_nulls_add_head(&ct->tuplehash[IP_CT_DIR_ORIGINAL].hnnode, > > > + &net->ct.dying); > > > spin_unlock_bh(&nf_conntrack_lock); > > > > i.o.w., conntrack objects that were in hash table are now always moved > > to the dying list. Shouldn't nf_ct_release_dying_list() be adjusted, > > too? It still seems to assume that the dying list only contains > > alive conntack objects whose events have not been delivered yet. > > I see, you mean that nf_ct_release_dying_list should delete objects > from the dying list. Yes, I'll fix that. Thanks for the spot. destroy_conntrack will delete the object from the dying list, so I think the code is fine. Am I missing anything? -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
