Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> On Sun, Nov 25, 2012 at 04:54:32PM +0100, Florian Westphal wrote:
> > 1. struct nlattr *attr[NFQA_MAX+1] must be initialized.
> > Otherwise, attr[FOO] might be non-null after parsing
> > even if that attribute isn't present in the message.
> >
> > 2. mnl_attr_get_payload will never return NULL (if the
> > attribute is NULL, it returns MNL_ATTR_HDRLEN.)
>
> Fine with me, just a question:
> > + puts("sleep 10 seconds");
> > + sleep(10);
>
> Why this sleep 10 seconds? :-)
Uhhh... Nothing to see here, move along ;-)
Thanks for spotting, i applied the patch (without
this leftover debug crud...).
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
