On Mon, 2012-11-19 at 18:21 +0100, Jozsef Kadlecsik wrote: > On Mon, 19 Nov 2012, Eric Dumazet wrote: > > > > This rcu_dereference() is probably wrong, looking at the context. > > (GFP_KERNEL allocations, or synchronize_net() a bit later. > > > > LOCKDEP will probably issue a splat here. > > > > Maybe you meant rtnl_dereference() instead, assuming RTNL is held here ? > > Yes, that is so. Do you spot any other RCU-related issue in the patch? Yes, please add __rcu qualifier in static struct ip_set __rcu **ip_set_list; /* all individual sets */ You should try : CONFIG_SPARSE_RCU_POINTER=y make C=2 net/netfilter/ipset/ip_set_core.o And spot all the places you access ip_set_list without proper rcu annotation. (some of them need the rcu_read_lock(), others need the rtnl_dereference() -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
