On Wed, 14 Nov 2012, Jan Engelhardt wrote:
> On Tuesday 2012-11-13 21:17, Jozsef Kadlecsik wrote:
>
> >+static int
> >+route_cmp(struct nf_conn *i, const struct fib_info *fi)
> >+{ [...]
> >+}
> >+
> >+static int masq_route_event(struct notifier_block *this,
> >+ unsigned long event,
> >+ void *ptr)
> >+{
> >+ if (event == NETDEV_ROUTE_CHANGED) {
> >+ /* Routing changed, delete marked entries */
> >+ nf_ct_iterate_cleanup(net, route_cmp,
> >+ (const struct fib_info)ptr);
>
> It would seem you forget a '*' near fib_info)ptr.
> The cast is pointless though, since ptr is already of type void *
> which nf_ct_iterate_cleanup expects.
You are right and it was not tested at all. Just a quick code to discuss
not only in theory but something real.
Best regards,
Jozsef
-
E-mail : kadlec@xxxxxxxxxxxxxxxxx, kadlecsik.jozsef@xxxxxxxxxxxxx
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
H-1525 Budapest 114, POB. 49, Hungary
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
