On Tue, Nov 13, 2012 at 09:59:30AM +0100, Florian Westphal wrote: > YOSHIFUJI Hideaki <yoshfuji@xxxxxxxxxxxxxx> wrote: > > pablo@xxxxxxxxxxxxx wrote: > > > From: Florian Westphal <fw@xxxxxxxxx> > > > + sin6.sin6_scope_id = sk->sk_bound_dev_if; > > > + > > > + nf_ct_put(ct); > > > + return copy_to_user(user, &sin6, sizeof(sin6)) ? -EFAULT : 0; > > > +} > > > + > > > > I think we should set sin6_scope_id to sk->sk_bound_dev_if only if the > > destination is link-local address. > > Right, I see that getpeer/sockname has this test. > > Dave, please either apply the patch as is (I'd submit a fixup) > or discard i, I'll then send a V2 with added > ipv6_addr_type(&sin->sin6_addr) & IPV6_ADDR_LINKLOCAL > test to Pablo. Please, send me a follow-up patch, I'll apply and request a new pull request. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
