Re: [PATCH 3/4] Add configure flag to disable NFLOG build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Le samedi 03 novembre 2012 à 15:41 +0100, Jan Engelhardt a écrit :
> 
> On Saturday 2012-11-03 12:33, Eric Leblond wrote:
> > 
> >+if BUILD_NFLOG
> > pkglib_LTLIBRARIES = ulogd_inppkt_NFLOG.la ulogd_inppkt_ULOG.la \
> >                        ulogd_inppkt_UNIXSOCK.la
> > 
> > ulogd_inppkt_NFLOG_la_SOURCES = ulogd_inppkt_NFLOG.c
> > ulogd_inppkt_NFLOG_la_LDFLAGS = -avoid-version -module $(LIBNETFILTER_LOG_LIBS)
> > ulogd_inppkt_NFLOG_la_CFLAGS = $(AM_CFLAGS) $(LIBNETFILTER_LOG_CFLAGS)
> >+else
> >+pkglib_LTLIBRARIES = ulogd_inppkt_ULOG.la ulogd_inppkt_UNIXSOCK.la
> >+endif
> 
> You can use
> 
>   pkglib_LTLIBRARIES = ulogd_inppkt_ULOG.la ulogd_inppkt_UNIXSOCK.la
>   if BUILD_NFLOG
>   pkglib_LTLIBRARIES += ulogd_inppkt_NFLOG.la
>   ...
>   endif
> 
> So that ulogd_inppkt_ULOG.la ulogd_inppkt_UNIXSOCK.la
> does not have to be listed twice.

You're right that's a better construction.

BR,
--
Eric


--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux