Re: [PATCH 2/2] netfilter: nf_tables: improve deletion performance

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Pablo,

--- a/net/netfilter/nf_tables_api.c
+++ b/net/netfilter/nf_tables_api.c
@@ -1289,7 +1289,7 @@ static void nf_tables_rule_destroy(const struct nft_ctx *ctx,
  		nf_tables_expr_destroy(ctx, expr);
  		expr = nft_expr_next(expr);
  	}
-	kfree(rule);
+	kfree_rcu(rule, rcu_head);
  }

Shouldn't it free the expression list at the same moment when the rule will actually be freed?
So call_rcu() instead of kfree_rcu().

Tomasz

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux