Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12-10-31 09:28 AM, Felipe Balbi wrote:
hi,

On Tue, Oct 30, 2012 at 05:18:56PM -0400, Behan Webster wrote:
The use of variable length arrays in structs (VLAIS) in the Linux Kernel code
precludes the use of compilers which don't implement VLAIS (for instance the
Clang compiler). This patch instead calculates offsets into the kmalloc-ed
memory buffer using macros from valign.h.

Signed-off-by: Behan Webster <behanw@xxxxxxxxxxxxxxxxxx>
this won't apply after the current cleanups I applied to gadget code
from Sebastian.
Makes sense. I'll try it with your repo, and regenerate.

If someone takes this patch, it will generate a series of annoying,
hard-to-figure-out conflicts (at least judging by the looks of
$SUBJECT).
I just tried the patch on your git.kernel.org repo and thankfully there is only one hunk which is rejected, and fortunately the reason is trivial (descriptors -> fs_descriptors).

Was:
-        func->function.descriptors = data->fs_descs;
+        func->function.descriptors = fs_descs;

Now is:
-        func->function.fs_descriptors = data->fs_descs;
+        func->function.fs_descriptors = fs_descs;

I will regenerate the patch set, but obviously the new gadget patch in the V3 patchset will only apply to the USB repo, and not to the netfilter repo.

Thanks,

Behan

--
Behan Webster
behanw@xxxxxxxxxxxxxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux