Re: [PATCH] netfilter: have r->cost != 0 case work

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 25, 2012 at 04:52:32PM +0200, Jan Engelhardt wrote:
> On Tuesday 2012-09-25 16:39, Pablo Neira Ayuso wrote:
> >On Sat, Sep 22, 2012 at 10:26:52AM +0200, Jan Engelhardt wrote:
> >> Commit v2.6.19-rc1~1272^2~41 tells us that r->cost != 0 can happen when
> >> a running state is saved to userspace and then reinstated from there.
> >> 
> >> Make sure that priv is initialized with some values when that happens.
> >
> >Just to clarify: With this patch, we go back to the situation in which
> >the state is reset on unrelated rule updates, right?
> 
> Before this patch, when userspace updated a rule, random things 
> would happen on matching due to use of uninitialized memory.

I know that ;-)

> Now, the values are initialized, and implies that the credit is reset on 
> table update.

This is what I wanted to confirm. Thanks Jan.

I'll pass this to David. Let's see if we can get this into 3.6-rc.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux